Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename spr config to ISR #27379

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Rename spr config to ISR #27379

merged 1 commit into from
Jul 22, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 21, 2021

This renames an old config to the modern naming.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jul 21, 2021
@ijjk
Copy link
Member Author

ijjk commented Jul 21, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js rename/spr-isr Change
buildDuration 14.8s 16.5s ⚠️ +1.6s
buildDurationCached 3.4s 3.3s -55ms
nodeModulesSize 49.5 MB 49.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js rename/spr-isr Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.602 2.767 ⚠️ +0.17
/ avg req/sec 960.98 903.38 ⚠️ -57.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.678 1.72 ⚠️ +0.04
/error-in-render avg req/sec 1490.03 1453.41 ⚠️ -36.62
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js rename/spr-isr Change
359.HASH.js gzip 2.96 kB 2.96 kB ✓
745.HASH.js gzip 180 B 180 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 21 kB 21 kB ✓
webpack-HASH.js gzip 1.53 kB 1.53 kB ✓
Overall change 67.9 kB 67.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js rename/spr-isr Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js rename/spr-isr Change
_app-HASH.js gzip 803 B 803 B ✓
_error-HASH.js gzip 3.06 kB 3.06 kB ✓
amp-HASH.js gzip 554 B 554 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.52 kB 2.52 kB ✓
head-HASH.js gzip 2.28 kB 2.28 kB ✓
hooks-HASH.js gzip 903 B 903 B ✓
image-HASH.js gzip 5.61 kB 5.61 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 19.1 kB 19.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js rename/spr-isr Change
_buildManifest.js gzip 490 B 490 B ✓
Overall change 490 B 490 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js rename/spr-isr Change
index.html gzip 530 B 530 B ✓
link.html gzip 543 B 543 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js rename/spr-isr Change
buildDuration 12.2s 12.1s -66ms
buildDurationCached 4.9s 4.8s -102ms
nodeModulesSize 49.5 MB 49.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js rename/spr-isr Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.6 2.694 ⚠️ +0.09
/ avg req/sec 961.68 927.86 ⚠️ -33.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.66 1.727 ⚠️ +0.07
/error-in-render avg req/sec 1506.03 1448 ⚠️ -58.03
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js rename/spr-isr Change
17.HASH.js gzip 2.98 kB 2.98 kB ✓
18.HASH.js gzip 185 B 185 B ✓
677f882d2ed8..HASH.js gzip 13.7 kB 13.7 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 8.4 kB 8.4 kB ✓
webpack-HASH.js gzip 1.22 kB 1.22 kB ✓
Overall change 68.5 kB 68.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js rename/spr-isr Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js rename/spr-isr Change
_app-HASH.js gzip 791 B 791 B ✓
_error-HASH.js gzip 3.76 kB 3.76 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.71 kB 2.71 kB ✓
head-HASH.js gzip 2.97 kB 2.97 kB ✓
hooks-HASH.js gzip 911 B 911 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 3.02 kB 3.02 kB ✓
withRouter-HASH.js gzip 294 B 294 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 17.6 kB 17.6 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js rename/spr-isr Change
_buildManifest.js gzip 500 B 500 B ✓
Overall change 500 B 500 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js rename/spr-isr Change
index.html gzip 577 B 577 B ✓
link.html gzip 588 B 588 B ✓
withRouter.html gzip 569 B 569 B ✓
Overall change 1.73 kB 1.73 kB ✓
Commit: 204c0ed

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk merged commit 52ae69a into vercel:canary Jul 22, 2021
@ijjk ijjk deleted the rename/spr-isr branch July 22, 2021 02:42
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Aug 19, 2021
@ijjk
Rename spr config to ISR (vercel#27379)
3a46fc7
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle